Re: Possible bug in logical replication.

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Arseny Sher <a.sher@postgrespro.ru>

Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Simon Riggs <simon@2ndquadrant.com>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, Sawada Masahiko <sawada.mshk@gmail.com>, konstantin knizhnik <k.knizhnik@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2018-06-20T05:33:04Z

Lists: pgsql-hackers

Attachments

slot-advance-comments.patch (text/x-diff) patch

On Mon, Jun 18, 2018 at 09:42:36PM +0900, Michael Paquier wrote:
> On Fri, Jun 15, 2018 at 06:27:56PM +0300, Arseny Sher wrote:
> It seems to me that we still want to have the slot forwarding finish in
> this case even if this is interrupted.  Petr, isn't that the intention
> here?

I have been chewing a bit more on the proposed patch, finishing with the
attached to close the loop.  Thoughts?
--
Michael

Commits

Rewrite comments in replication slot advance implementation
- 96bd49437cca 11.0 landed
- 1573995f5599 12.0 landed
Fix a couple of bugs with replication slot advancing feature
- f731cfa94c00 11.0 landed
Ability to advance replication slots
- 9c7d06d60680 11.0 cited