Re: Portability concerns over pq_sendbyte?
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>, pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Date: 2018-06-11T05:25:44Z
Lists: pgsql-hackers
On Wed, Jun 06, 2018 at 12:27:58PM -0400, Alvaro Herrera wrote: > Do you have an answer to this question? Does anybody else? > > (My guts tell me it'd be better to change these routines to take > unsigned values, without creating extra variants. But guts frequently > misspeak.) My guts are telling me as well to not have more variants. On top of that it seems to me that we'd want to rename any new routines to include "uint" in their name instead of "int", and for compatibility with past code pq_sendint should not be touched. -- Michael
Commits
-
Change pqformat.h's integer handling functions to take unsigned integers.
- 42121790ca9b 11.0 landed