Horton

Re: SHOW ALL does not honor pg_read_all_settings membership

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Simon Riggs <simon@2ndquadrant.com>, Laurenz Albe <laurenz.albe@cybertec.at>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-06-11T01:38:14Z
Lists: pgsql-hackers 
On Fri, Jun 08, 2018 at 03:13:57PM -0400, Alvaro Herrera wrote:
> And I think this fixes it.

-    if (conf->source == PGC_S_FILE && superuser())
+    if (conf->source == PGC_S_FILE &&
+        is_member_of_role(GetUserId(), DEFAULT_ROLE_READ_ALL_SETTINGS))

Thanks Alvaro!  This bit in GetConfigOptionByNum() looks fine to me.
--
Michael

Commits

  1. Teach SHOW ALL to honor pg_read_all_settings membership

  2. Default monitoring roles