Horton

Re: Needless additional partition check in INSERT?

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Simon Riggs <simon@2ndquadrant.com>, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Robert Haas <robertmhaas@gmail.com>, Amit Langote <amitlangote09@gmail.com>, Amit Khandekar <amitdkhan.pg@gmail.com>
Date: 2018-06-07T03:57:32Z
Lists: pgsql-hackers 
On 2018-Jun-07, David Rowley wrote:

> Hi Alvaro,
> 
> Thanks for looking at this. I thought it was strange to pass in both
> resultRelInfos. I ended up just making the 2nd param a bool to
> indicate of tuple routing was used.

Good call.

> I'm personally not really for or against having the function. I agree
> that it's slightly weird, but anyway, here's the patch. I'll leave it
> up to you to which one you prefer, v3 or v4.

Hm I was thinking this new function would be companion to ExecConstrains
(a fact I used in the name I proposed,) so it'd be in the same file
(probably right after it.)


-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Don't needlessly check the partition contraint twice