Horton

Re: A Japanese-unfriendy error message contruction

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>

View thread View on postgr.es
From: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
To: tgl@sss.pgh.pa.us
Cc: pgsql-hackers@postgresql.org
Date: 2018-05-25T01:05:14Z
Lists: pgsql-hackers 
At Thu, 24 May 2018 14:20:21 -0400, Tom Lane <tgl@sss.pgh.pa.us> wrote in <24988.1527186021@sss.pgh.pa.us>
> Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> > Hello. Here is the patch set.
> 
> Thanks!  I pushed all this plus fixes for the OCLASS_PUBLICATION_REL
> code.

Thanks.

> The only non-cosmetic change I made was that I didn't much like what
> you'd done with the OCLASS_DEFACL code: it seemed quite confusing to
> be renaming buffers like that, plus it was still assuming more than
> I thought it should about how the message would go together in the end.
> I took the advice of the manual instead, and just made pairs of
> near-duplicate messages to be translated separately.

I wasn't sure that which way is better. This doubles the
msgids. But I can live with it since it would be scaecely
changed.

> I'm still not sure whether the OCLASS_DEFAULT case is satisfactorily
> translatable.  It would not take a lot more code to expand its message to
> "default value for column %s of %s", where the second %s is the result of
> getRelationDescription.  However, I have no idea whether there are any
> translations where that would really work noticeably better.

True. I think we don't have difficulties as for Japanese
translation.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Improve English wording of some other getObjectDescription() messages.

  2. Improve translatability of some getObjectDescription() messages.

  3. Fix objectaddress.c code for publication relations.

  4. Properly schema-qualify additional object types in getObjectDescription().