Re: perlcritic and perltidy

Stephen Frost <sfrost@snowman.net>

From: Stephen Frost <sfrost@snowman.net>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: David Steele <david@pgmasters.net>, Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-05-08T17:18:58Z
Lists: pgsql-hackers
Andrew,

* Andrew Dunstan (andrew.dunstan@2ndquadrant.com) wrote:
> On 05/08/2018 12:51 PM, Stephen Frost wrote:
> > * Andrew Dunstan (andrew.dunstan@2ndquadrant.com) wrote:
> > There's not much point adding the ',' unless you're also putting the
> > ');' on the next line, is there..?
> 
> No, not really.
> 
> > Or is that going to be handled in a follow-up patch?
> 
> No, the current proposal is to keep the vertical tightness settings for
> parentheses, which is precisely this set of cases, because otherwise
> there are some ugly code efects (see Peter's email upthread)
> 
> So I think we're all in agreement to fortget this trailing comma thing.

Well, agreed, for parentheses, but for curly-brace blocks, it'd be nice to
have them since those will end up on their own line, right?

Thanks!

Stephen

Commits

  1. Don't force a blank line before comments in perl code

  2. Restrict vertical tightness to parentheses in Perl code