Horton

Re: perlcritic and perltidy

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, David Steele <david@pgmasters.net>, Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-05-08T17:02:51Z
Lists: pgsql-hackers 
Stephen Frost wrote:

> * Andrew Dunstan (andrew.dunstan@2ndquadrant.com) wrote:
>
> > -		'XLogRecPtr'    => 'pg_lsn');
> > +		'XLogRecPtr'    => 'pg_lsn',);
>
> There's not much point adding the ',' unless you're also putting the
> ');' on the next line, is there..?
> 
> Or is that going to be handled in a follow-up patch?

IMO we should classify this one as pointless uglification and move on.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Don't force a blank line before comments in perl code

  2. Restrict vertical tightness to parentheses in Perl code