Re: perlcritic and perltidy

Greetings,

* Alvaro Herrera (alvherre@2ndquadrant.com) wrote:
> Stephen Frost wrote:
> 
> > * Andrew Dunstan (andrew.dunstan@2ndquadrant.com) wrote:
> >
> > > -		'XLogRecPtr'    => 'pg_lsn');
> > > +		'XLogRecPtr'    => 'pg_lsn',);
> >
> > There's not much point adding the ',' unless you're also putting the
> > ');' on the next line, is there..?
> > 
> > Or is that going to be handled in a follow-up patch?
> 
> IMO we should classify this one as pointless uglification and move on.

I'm all for the change if we actually get to a result where the lines
can be moved and you don't have to go muck with the extra stuff at the
end of the line (add a comma, or remove a comma, remove or add the
parens, etc).  If we aren't going all the way to get to that point then
I tend to agree that it's not a useful change to make.

Thanks!

Stephen