Horton

Re: perlcritic and perltidy

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Stephen Frost <sfrost@snowman.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-05-07T00:23:50Z
Lists: pgsql-hackers 
On Sun, May 06, 2018 at 01:46:28PM -0400, Stephen Frost wrote:
> I definitely prefer to have the braces on their own line- makes working
> with the files a lot easier when you've got a lot of hashes
> (particularly thinking about the hashes for the pg_dump regression
> tests..).  Having them on independent lines would have saved me quite a
> few keystrokes when I reworked those tests.

Agreed with Stephen's argument.  Let's keep the braces on the same
line.  I have also been annoyed a couple of times with the format which
adds a new line just for a brace.
--
Michael

Commits

  1. Don't force a blank line before comments in perl code

  2. Restrict vertical tightness to parentheses in Perl code