Horton

Re: initdb fails to initialize data directory

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Nikhil Sontakke <nikhils@2ndquadrant.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2018-04-19T19:59:44Z
Lists: pgsql-hackers 
Heikki Linnakangas wrote:

> Nitpick: using MAXPGPATH seems for the buffer size seems to wrong to me.
> We're not storing a path here. MAXPGPATH is 1024 by default, which seems
> fine, but I would've spelled it out directly as "line[1000]".

Hmm ... yeah, kinda.  Do you care about it strongly enough for me to fix
it in all branches?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Enlarge find_other_exec's meager fgets buffer