Horton

Re: BUG #15150: Reading uninitialised value in NISortAffixes (tsearch/spell.c)

Artur Zakirov <a.zakirov@postgrespro.ru>

View thread View on postgr.es
From: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2018-04-13T19:05:30Z
Lists: pgsql-bugs 
On Fri, Apr 13, 2018 at 01:51:00PM -0400, Tom Lane wrote:
> > I attached the patch. It fixes the following:
> > - show an error if actual number of affix aliases is greater than
> >   initial number. I wonder is it necessary. But I think it is better to
> >   raise an error than crash, if you set wrong number for AF flag.
> 
> Good idea, but I tweaked the message wording a bit.
> 
> > The code coverage still isn't 100% for spell.c. But it is better than
> > earlier.
> 
> Indeed.  Pushed, thanks!

Thank you!

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Commits

  1. Improve regression test coverage for src/backend/tsearch/spell.c.

  2. Fix bogus affix-merging code.