Horton

Re: Make description of heap records more talkative for flags

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2018-04-13T03:49:03Z
Lists: pgsql-hackers 
On 2018-04-13 12:47:34 +0900, Michael Paquier wrote:
> Hi all,
> 
> I was just playing with the WAL consistency issue with rows moved across
> partitions when I noticed that heapdesc.c is not really talkative about
> the different flag records set.
> 
> What about something like the patch attached?  I found that useful for
> debugging.
> 
> (One comment of heapam_xlog.h mentions xl_heap_delete instead of
> xl_heap_truncate, noticed it on the way.)

OTOH, that also kinda bloats the output noticeably... I'm somewhat
inclined to just put the hex value or such there?

Greetings,

Andres Freund

Commits

  1. Add flag values in WAL description to all heap records

  2. Fix incorrect routine name in xlog_heapam.h