Re: 'make check' fails

On Wed, Apr 11, 2018 at 01:04:56PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Wed, Apr 11, 2018 at 12:35:41PM -0400, Tom Lane wrote:
> >> We can fix this by making submake-generated-headers be a recursive
> >> prerequisite for "check" as well as "all" and "install".  I wonder
> >> whether anybody is expecting any other shortcuts to work.
> 
> > In case it wasn't clear, I can reproduce this failure without parallel
> > mode.  FYI, the reason I used this shortcut is so I can just run one
> > command and check one error code to know if they all worked;  see
> > src/tools/pgtest for an example.
> 
> Probably, you got out of the habit of using parallel mode because it
> fell over from time to time.  The way things were done before, there
> independently trying to update the same generated headers.

I do use parallel make but was testing without it just in case.

> Will commit a fix in a bit.

I can confirm the fix.  Thanks.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +