Thread

Commits

  1. Fix a few typos in comments and variable names.

  1. Typos from Covering Index patch

    Michael Paquier <michael@paquier.xyz> — 2018-04-11T07:52:23Z

    Hi all,
    
    I am catching up with new features so I have begun going through
    Covering indexes.  While reading the code, I have noticed a couple of
    things:
    1) Some typos.
    2) An inconsistent variable name in pg_dump.
    
    The thing and structure of the code is pretty interesting by the way.
    That's nice work.  I am still trying to break the DDL data like
    NULL-ness of columns for some weird combinations of columns without
    being able to.
    
    Thanks,
    --
    Michael
    
  2. Re: Typos from Covering Index patch

    Heikki Linnakangas <hlinnaka@iki.fi> — 2018-04-17T15:57:06Z

    On 11/04/18 03:52, Michael Paquier wrote:
    > Hi all,
    > 
    > I am catching up with new features so I have begun going through
    > Covering indexes.  While reading the code, I have noticed a couple of
    > things:
    > 1) Some typos.
    > 2) An inconsistent variable name in pg_dump.
    
    Committed, thanks!
    
    - Heikki
    
    
    
  3. Re: Typos from Covering Index patch

    Heikki Linnakangas <hlinnaka@iki.fi> — 2018-04-17T15:57:20Z

    On 11/04/18 03:52, Michael Paquier wrote:
    > Hi all,
    > 
    > I am catching up with new features so I have begun going through
    > Covering indexes.  While reading the code, I have noticed a couple of
    > things:
    > 1) Some typos.
    > 2) An inconsistent variable name in pg_dump.
    
    Committed, thanks!
    
    - Heikki
    
    
    
  4. Re: Typos from Covering Index patch

    Michael Paquier <michael@paquier.xyz> — 2018-04-18T00:14:41Z

    On Tue, Apr 17, 2018 at 11:57:20AM -0400, Heikki Linnakangas wrote:
    > Committed, thanks!
    
    Thanks, Heikki.
    --
    Michael