Horton

Re: Mop-up for the bootstrap data conversion patch

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org, John Naylor <jcnaylor@gmail.com>
Date: 2018-04-07T12:31:48Z
Lists: pgsql-hackers 
On Sat, Apr 07, 2018 at 09:25:44AM -0300, Alvaro Herrera wrote:
> Tom Lane wrote:
>> I've always felt that the pg_foo_fn.h business was a kluge, and would
>> be happy to get rid of it.  But one could also argue that it would be
>> a good design, if we adopted it uniformly instead of haphazardly.
>> But that'd require more code churn, and there's no longer a lot to be
>> gained thereby.
> 
> I vote for removing pg_foo_fn.h.

+1 on that.
--
Michael

Commits

  1. Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.

  2. Switch client-side code to include catalog/pg_foo_d.h not pg_foo.h.