Horton

Re: Mop-up for the bootstrap data conversion patch

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, John Naylor <jcnaylor@gmail.com>
Date: 2018-04-07T12:25:44Z
Lists: pgsql-hackers 
Tom Lane wrote:

> I've always felt that the pg_foo_fn.h business was a kluge, and would
> be happy to get rid of it.  But one could also argue that it would be
> a good design, if we adopted it uniformly instead of haphazardly.
> But that'd require more code churn, and there's no longer a lot to be
> gained thereby.

I vote for removing pg_foo_fn.h.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.

  2. Switch client-side code to include catalog/pg_foo_d.h not pg_foo.h.