Re: PATCH: Configurable file mode mask

Stephen Frost <sfrost@snowman.net>

From: Stephen Frost <sfrost@snowman.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: David Steele <david@pgmasters.net>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Adam Brightwell <adam.brightwell@crunchydata.com>, Robert Haas <robertmhaas@gmail.com>, "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-04-06T19:04:25Z
Lists: pgsql-hackers
Michael,

* Michael Paquier (michael@paquier.xyz) wrote:
> On Fri, Apr 06, 2018 at 09:15:15AM -0400, Stephen Frost wrote:
> > I'll reply to David's last email (where the latest set of patches were
> > included) with my comments/suggestions and I expect we'll be able to get
> > those addressed today and have a final patch to post tonight, with an
> > eye towards committing it tomorrow.
> 
> The feature freeze is on the 8th, so I am going to have limited room to
> comment on things until that day.  If something gets committed, I am
> pretty sure that I'll get out of my pocket a couple of things to improve
> the feature and its interface anyway if of course you are ready to
> accept that.  I have limited my role to be a reviewer, so I refrained
> myself from writing any code ;)

I'm, of course, happy to accept any further comments or suggestions on
it, pre-commit, post-commit, next year, whenever. ;)

I've posted an updated patch with comments and next steps, as discussed,
which I'm hopeful that David will have a chance to review and comment
on, at least, and perhaps help wrap up those last items.  This patch has
been quite a slog, so thank you again for all of your help reviewing it
and moving it forward, it's been really appreciated.

Thanks!

Stephen

Commits

  1. Allow group access on PGDATA

  2. Refactor dir/file permissions

  3. Revert "Add basic TAP test setup for pg_upgrade"

  4. Add basic TAP test setup for pg_upgrade