Horton

Re: BUG #14941: Vacuum crashes

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: "Bossart, Nathan" <bossartn@amazon.com>
Cc: Andres Freund <andres@anarazel.de>, Masahiko Sawada <sawada.mshk@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Lyes Ameddah <lyes.amd@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, "pgsql-bugs@postgresql.org" <pgsql-bugs@postgresql.org>
Date: 2018-04-05T21:41:14Z
Lists: pgsql-bugs, pgsql-hackers 
On Thu, Apr 05, 2018 at 08:29:38PM +0000, Bossart, Nathan wrote:
> The new tests are now passing as expected, but I am still doing some
> manual testing.  Since there is quite a bit of added complexity in
> this new patch set, I will certainly not be surprised if this gets
> moved to the next commitfest.

That would be wiser.  We are two days away from the end of the CF and
this patch gets quite invasive with a set of new concepts, so my
recommendation would be to do so.  There has been already much done with
the introduction of the new grammar for ANALYZE, and the introduction of
RangeVarGetRelidExtended().
--
Michael

Commits

  1. Add option SKIP_LOCKED to VACUUM and ANALYZE

  2. Rename VACOPT_NOWAIT to VACOPT_SKIP_LOCKED

  3. Add parenthesized options syntax for ANALYZE.

  4. Don't allow VACUUM VERBOSE ANALYZE VERBOSE.

  5. Fix inadequate locking during get_rel_oids().

  6. Avoid having autovacuum workers wait for relation locks.