Re: [HACKERS] GUC for cleanup indexes threshold.

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>

From: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>

To: sawada.mshk@gmail.com

Cc: teodor@sigaev.ru, a.korotkov@postgrespro.ru, simon@2ndquadrant.com, y.sokolov@postgrespro.ru, pg@bowt.ie, andres@anarazel.de, robertmhaas@gmail.com, david@pgmasters.net, amit.kapila16@gmail.com, ideriha.takeshi@jp.fujitsu.com, pgsql-hackers@postgresql.org, kuntalghosh.2007@gmail.com, pgsql-hackers-owner@postgresql.org

Date: 2018-04-05T09:17:30Z

Lists: pgsql-hackers

Attachments

remove_unused_variables_nbt.patch (text/x-patch) patch
remove_unused_variables_nodemerge.patch (text/x-patch) patch

Hello.

The commit leaves three warnings for
-Wunused-but-set-variable. Two of them are not assertion-only but
really not used at all.

I also found that nodeMerge.c has one such variable.

regards.

At Thu, 5 Apr 2018 15:43:55 +0900, Masahiko Sawada <sawada.mshk@gmail.com> wrote in <CAD21AoAtYzXeuhPqGw89KxqcJWpSKxWRNkYzyJxAqJHZham==Q@mail.gmail.com>
> On Thu, Apr 5, 2018 at 2:40 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > On Thu, Apr 5, 2018 at 1:30 AM, Teodor Sigaev <teodor@sigaev.ru> wrote:
> >> Thanks for everyone, pushed with minor editorization
> >>
> >
> > Thank you for committing!
> > I found a typo in nbtpage.c and attached a patch fixes it.
> >
> 
> I also found an incorrect documentation in create_index.sgml as follows.
> 
>      <term><literal>vacuum_cleanup_index_scale_factor</literal></term>
>      <listitem>
>      <para>
>       Per-table value for <xref
> linkend="guc-vacuum-cleanup-index-scale-factor"/>.
>      </para>
>      </listitem>
>     </varlistentry>
> 
> I think it should be "Per-index". Attached a patch for fixing it. And
> sorry for missing it at review.
> 
> Regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

Fix upper limit for vacuum_cleanup_index_scale_factor
- 4d54543efa5e 11.0 landed
Increase upper limit for vacuum_cleanup_index_scale_factor
- 6ca33a885bf8 11.0 landed
Fixes for vacuum_cleanup_index_scale_factor GUC option
- 9a994e37e08d 11.0 landed
Skip full index scan during cleanup of B-tree indexes when possible
- 857f9c36cda5 11.0 landed