Re: Add default role 'pg_access_server_files'
Stephen Frost <sfrost@snowman.net>
From: Stephen Frost <sfrost@snowman.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-04-01T13:39:02Z
Lists: pgsql-hackers
Attachments
- add_default_role_access_server_files_v5-master.patch (text/x-diff) patch v5-0001
Greetings, * Michael Paquier (michael@paquier.xyz) wrote: > On Sun, Mar 25, 2018 at 09:43:25PM -0400, Stephen Frost wrote: > > * Michael Paquier (michael@paquier.xyz) wrote: > >> On Thu, Mar 08, 2018 at 10:15:11AM +0900, Michael Paquier wrote: > >> > Other than that the patch looks in pretty good shape to me. > >> > >> The regression tests of file_fdw are blowing up because of an error > >> string patch 2 changes. > > > > Fixed in the attached. > > Thanks for the updated version. This test is fixed. Thanks for checking. Attached is an updated version which also includes the changes for adminpack, done in a similar manner to how pgstattuple was updated, as discussed. Regression tests updated and extended a bit, doc updates also included. If you get a chance to take a look, that'd be great. I'll do my own review of it again also after stepping away for a day or so. Thanks! Stephen
Commits
-
Add default roles for file/program access
- 0fdc8495bff0 11.0 landed
-
Remove explicit superuser checks in favor of ACLs
- e79350fef291 11.0 landed
-
Support new default roles with adminpack
- 11523e860f8f 11.0 landed