Horton

Re: Fix permissions check on pg_stat_get_wal_senders

Michael Paquier <michael.paquier@gmail.com>

View thread
From: Michael Paquier <michael.paquier@gmail.com>
To: Feike Steenbergen <feikesteenbergen@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>, Simon Riggs <simon@2ndquadrant.com>
Date: 2017-12-23T10:56:26Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Default monitoring roles

On Fri, Dec 22, 2017 at 07:49:34AM +0100, Feike Steenbergen wrote:
> On 21 December 2017 at 14:11, Michael Paquier <michael.paquier@gmail.com> wrote:
> > You mean a WAL receiver here, not a WAL sender.
> 
> Fixed, thanks

[nit]
 		/*
 -		 * Only superusers can see details. Other users only get the pid value
+		 * Only superusers and members of pg_read_all_stats can see details.
+		 * Other users only get the pid value
 		 * to know whether it is a WAL receiver, but no details.
 		 */

Incorrect comment format.
[/nit]

Committers run pgindent on each patch before committing anyway, and what
you are proposing here looks good to me, so I am marking that as ready for
committer. Simon, as the original committer of 25fff407, could you look
at what is proposed here?
--
Michael