Horton

Re: Reproducible builds: genbki.pl and Gen_fmgrtab.pl

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Christoph Berg <christoph.berg@credativ.de>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, Michael Paquier <michael.paquier@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-12-21T14:18:03Z
Lists: pgsql-hackers 
Christoph Berg wrote:
> Re: Andrew Dunstan 2017-12-21 <d68d254a-6f97-a8c2-4656-ab8886fe2c38@2ndQuadrant.com>

> > I've found it annoying in the past. Probably now that the buildfarm
> > reports each test series separately it matters less. Previously we
> > reported many of the TAP tests together.
> 
> Rename them to the directory name:
> 
>     ./src/bin/pg_rewind/t/001_pg_rewind.pl
>     ./src/test/modules/commit_ts/t/001_commit_ts.pl
>     ./src/test/modules/test_pg_dump/t/001_test_pg_dump.pl

These sound good to me.

>     ./src/bin/pg_dump/t/001_pg_dump.pl

There already is t/002_pg_dump.pl.  src/bin/pg_dump/t/001_basic.pl is
all about command lines, perhaps we can find a name that evokes that --
001_dump_cmdline.pl?  (prefixed "_dump_" to be in line with
t/010_dump_connstr.pl)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Avoid putting build-location-dependent strings into generated files.