Horton

Re: Reproducible builds: genbki.pl and Gen_fmgrtab.pl

Christoph Berg <christoph.berg@credativ.de>

View thread View on postgr.es
From: Christoph Berg <christoph.berg@credativ.de>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Michael Paquier <michael.paquier@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-12-21T13:56:29Z
Lists: pgsql-hackers 
Re: Andrew Dunstan 2017-12-21 <d68d254a-6f97-a8c2-4656-ab8886fe2c38@2ndQuadrant.com>
> >>     ./src/bin/pg_dump/t/001_basic.pl
> >>     ./src/bin/pg_rewind/t/001_basic.pl
> >>     ./src/test/modules/commit_ts/t/001_base.pl
> >>     ./src/test/modules/test_pg_dump/t/001_base.pl
> > Why does the uniqueness of application_name set in the TAP test suite
> > matter? Each instance of Postgres is self-contained into its own Unix
> > domain path and port.
> 
> I've found it annoying in the past. Probably now that the buildfarm
> reports each test series separately it matters less. Previously we
> reported many of the TAP tests together.

Rename them to the directory name:

    ./src/bin/pg_dump/t/001_pg_dump.pl
    ./src/bin/pg_rewind/t/001_pg_rewind.pl
    ./src/test/modules/commit_ts/t/001_commit_ts.pl
    ./src/test/modules/test_pg_dump/t/001_test_pg_dump.pl

Christoph
-- 
Senior Berater, Tel.: +49 2166 9901 187
credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
pgp fingerprint: 5C48 FE61 57F4 9179 5970  87C6 4C5A 6BAB 12D2 A7AE

Commits

  1. Avoid putting build-location-dependent strings into generated files.