Reproducible builds: genbki.pl vs schemapg.h

Christoph Berg <christoph.berg@credativ.de>

From: Christoph Berg <christoph.berg@credativ.de>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-12-15T10:22:23Z
Lists: pgsql-hackers

Attachments

Hi,

Debian's reproducible builds project has revealed that the full build
path gets embedded into server/catalog/schemapg.h:

/*-------------------------------------------------------------------------
 *
 * schemapg.h
 *    Schema_pg_xxx macros for use by relcache.c
 *
 * Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group
 * Portions Copyright (c) 1994, Regents of the University of California
 *
 * NOTES
 *  ******************************
 *  *** DO NOT EDIT THIS FILE! ***
 *  ******************************
 *
 *  It has been GENERATED by /build/postgresql-11-05gRdu/build/../src/backend/catalog/genbki.pl
 *
 *-------------------------------------------------------------------------
 */

This information will vary on rebuilding the binaries, needlessly
causing different checksums.

I'm proposing to strip that down to "It has been GENERATED genbki.pl".
Patch attached.

Christoph

Commits

  1. Avoid putting build-location-dependent strings into generated files.