Horton

Re: [HACKERS] Small improvement to compactify_tuples

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Юрий Соколов <funny.falcon@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Tom Lane <tgl@sss.pgh.pa.us>, Claudio Freire <klaussfreire@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Sokolov Yura <funny.falcon@postgrespro.ru>, Alvaro Herrera <alvherre@2ndquadrant.com>, Heikki Linnakangas <hlinnaka@iki.fi>, PostgreSQL-Dev <pgsql-hackers@postgresql.org>
Date: 2017-11-28T22:41:50Z
Lists: pgsql-hackers 
Hi,

On 2017-11-28 23:30:53 +0300, Юрий Соколов wrote:
> index 1a8ee08c8b..607ed6a781 100644
> --- a/src/port/qsort.c
> +++ b/src/port/qsort.c
> @@ -8,7 +8,7 @@
>   *	  in favor of a simple check for presorted input.
>   *	  Take care to recurse on the smaller partition, to bound stack usage.
>   *
> - *	CAUTION: if you change this file, see also qsort_arg.c, gen_qsort_tuple.pl
> + *	CAUTION: if you change this file, see also qsort_arg.c, qsort_template.h
>   *
>   *	src/port/qsort.c
>   */

Maybe it's a stupid question. But would we still want to have this after
the change? These should be just specializations of the template version
imo.

Greetings,

Andres Freund

Commits

  1. Avoid looping through line pointers twice in PageRepairFragmentation().

  2. Reduce pinning and buffer content locking for btree scans.

  3. Speed up in-memory tuplesorting.