Re: Rewriting PL/Python's typeio code
Anthony Bykov <a.bykov@postgrespro.ru>
From: Anthony Bykov <a.bykov@postgrespro.ru>
To: pgsql-hackers@postgresql.org
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-11-15T11:08:23Z
Lists: pgsql-hackers
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: not tested Documentation: tested, passed Hello, I have checked your patch. Everything looks fine for me, but I have some doubts: 1. In file plpy_exec.c there is a typo on line 347: "... We use the result and resultin[should be here "g"?] variables... 2. In file plpy_cursorobject.c there is a non-volatile variable "elem" used in try-except construction. Is that OK? -- Anthony Bykov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company The new status of this patch is: Waiting on Author
Commits
-
Make PL/Python handle domain-type conversions correctly.
- 687f096ea9da 11.0 landed
-
Support arrays over domains.
- c12d570fa147 11.0 cited