Re: path toward faster partition pruning
Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Hello,
At Fri, 10 Nov 2017 14:44:55 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote in <20171110.144455.117208639.horiguchi.kyotaro@lab.ntt.co.jp>
> > Those two conditions are not orthogonal. Maybe something like
> > following seems more understantable.
> >
> > > if (!constfalse)
> > > {
> > > /* No constraints on the keys, so, return *all* partitions. */
> > > if (nkeys == 0)
> > > return bms_add_range(result, 0, partdesc->nparts - 1);
> > >
> > > result = get_partitions_for_keys(relation, &keys);
> > > }
So, the condition (!constfalse && nkeys == 0) cannot return
there. I'm badly confused by the variable name.
I couldn't find another reasonable structure using the current
classify_p_b_keys(), but could you add a comment like the
following as an example?
+ /*
+ * Ths function processes other than OR expressions and returns
+ * the excluded OR expressions in or_clauses
+ */
> nkeys = classify_partition_bounding_keys(relation, clauses,
> &keys, &constfalse,
> &or_clauses);
> /*
> * Only look up in the partition decriptor if the query provides
> * constraints on the keys at all.
> */
> if (!constfalse)
> {
> if (nkey > 0)
> result = get_partitions_for_keys(relation, &keys);
> else
-+ /* No constraints on the keys, so, all partitions are passed. */
> result = bms_add_range(result, 0, partdesc->nparts - 1);
> }
>
+ /*
+ * We have a partition set for clauses not returned in or_clauses
+ * here. Conjuct the result of each OR clauses.
+ */
> foreach(lc, or_clauses)
> {
> BoolExpr *or = (BoolExpr *) lfirst(lc);
> ListCell *lc1;
> Bitmapset *or_partset = NULL;
>
+ Assert(or_clause(or));
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
Commits
-
Fix assorted partition pruning bugs
- d758d9702e2f 11.0 landed
-
Make gen_partprune_steps static
- d1e2cac5ff7e 11.0 landed
-
Remove useless 'default' clause
- c775fb9e18ac 11.0 landed
-
Reorganize partitioning code
- da6f3e45ddb6 11.0 landed
-
Use custom hash opclass for hash partition pruning
- fafec4cce814 11.0 landed
-
Blindly attempt to fix sepgsql tests broken due to 9fdb675fc5.
- 4f813c7203e0 11.0 landed
-
Attempt to fix endianess issues in new hash partition test.
- 40e42e1024c5 11.0 landed
-
Faster partition pruning
- 9fdb675fc5d2 11.0 landed
-
For partitionwise join, match on partcollation, not parttypcoll.
- 2af28e603319 11.0 landed
-
Revise API for partition bound search functions.
- f724022d0ae0 11.0 landed
-
Revise API for partition_rbound_cmp/partition_rbound_datum_cmp.
- b0229235564f 11.0 landed
-
Fix possible crash in partition-wise join.
- f069c91a5793 11.0 cited
-
Refactor code for partition bound searching
- 9aef173163ae 11.0 landed
-
New C function: bms_add_range
- 84940644de93 11.0 landed
-
Add extensive tests for partition pruning.
- 8d4e70a63bf8 11.0 landed
-
Add null test to partition constraint for default range partitions.
- 7b88d63a9122 11.0 cited
-
Remove BufFile's isTemp flag.
- 11e264517dff 11.0 cited
-
Make OWNER TO subcommand mention consistent
- bf54c0f05c0a 11.0 cited
-
Fix index matching for operators with mixed collatable/noncollatable inputs.
- cb37c291060d 9.2.0 cited