Horton

Re: pgbench - use enum for meta commands

Aleksandr Parfenov <a.parfenov@postgrespro.ru>

View thread View on postgr.es
From: Aleksandr Parfenov <a.parfenov@postgrespro.ru>
To: pgsql-hackers@postgresql.org
Cc: Fabien Coelho <postgresql.org@coelho.net>
Date: 2017-11-02T14:29:18Z
Lists: pgsql-hackers 
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi,

Looks good to me.

The only thing I'm not quite sure about is a comment "which meta command ...".
Maybe it's better to write it without question word, something like "meta command identifier..."?

The new status of this patch is: Ready for Committer

Commits

  1. pgbench: replace run-time string comparisons with an enum identifier.