Re: BUG #14843: CREATE TABLE churns through all memory, crashes db

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael.paquier@gmail.com>, ropeladder@gmail.com, PostgreSQL mailing lists <pgsql-bugs@postgresql.org>
Date: 2017-10-06T18:27:15Z
Lists: pgsql-bugs
On 2017-10-06 14:18:57 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > It's "just" a MemoryContextSwitchTo() that some idiot^WI forgot and
> > reviews didn't spot.
> 
> Yeah, I had just come to the same conclusion.  I have a fix about ready
> to commit, unless you're nearly there ...

Please go ahead in that case.

Thanks,

Andres


Commits

  1. Fix intra-query memory leakage in nodeProjectSet.c.

  2. Move targetlist SRF handling from expression evaluation to new executor node.