Re: pg_ctl kill support for KILL signal was Re: [COMMITTERS] pgsql: Add test for postmaster crash restarts.
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-10-01T20:48:54Z
Lists: pgsql-hackers
On 2017-10-01 16:42:44 -0400, Tom Lane wrote: > Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes: > > On 09/30/2017 10:32 PM, Andres Freund wrote: > >> Heh. I'm inclined to take it out. We could add a --use-the-force-luke > >> type parameter, but it doesn't seem worth it. > > > I agree, but I think we need this discussed on -hackers. Does anyone > > have an objection to allowing "pg_ctl kill KILL somepid"? As Andres > > points out, in most places you can just call kill from the command line > > anyway, so disallowing it is not really a security feature. Having it > > would let us have portable crash restart tests. > > +1 for portable tests, but it still seems like something we don't want > to encourage users to use. What do you think of leaving it out of the > documentation? As far as I can tell we've not documented the set of acceptable signals anywhere but the source. I think we can just keep it that way? Greetings, Andres Freund
Commits
-
Allow pg_ctl kill to send SIGKILL.
- 2e83db3ad2da 11.0 landed
-
Try to make crash restart test work on windows.
- 784905795f8a 11.0 landed
-
Make new crash restart test a bit more robust.
- 1910353675bd 11.0 landed
-
Add test for postmaster crash restarts.
- a1924a4ea293 11.0 cited