Horton

Re: [BUGS] Bug in Physical Replication Slots (at least 9.5)?

Tatsuo Ishii <ishii@sraoss.co.jp>

View thread View on postgr.es
From: Tatsuo Ishii <ishii@sraoss.co.jp>
To: michael.paquier@gmail.com
Cc: ishii@sraoss.co.jp, nag1010@gmail.com, horiguchi.kyotaro@lab.ntt.co.jp, jdnelson@dyn.com, pgsql-hackers@postgresql.org, pgsql-bugs@postgresql.org
Date: 2017-03-30T00:51:47Z
Lists: pgsql-bugs, pgsql-hackers 
> On Thu, Mar 30, 2017 at 9:12 AM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>> Committers will not apply patches which has trailing whitespace
>> issues. So the patch submitter needs to fix them anyway.
> 
> I cannot comment on that point (committers are free to pick up things
> the way they want), but just using git commands to apply a patch
> should not be an obstacle for a review if a patch can be easily
> applied as long as they roughly respect GNU's diff format.

My point is, the coding standard. Having trainling whitespace is
against our coding standard and committers should not accept such a
code, I believe.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

Commits

  1. Fix scenario where streaming standby gets stuck at a continuation record.