Horton

Re: Valgrind failures caused by multivariate stats patch

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Tomas Vondra <tv@fuzzy.cz>
Date: 2017-03-28T15:11:14Z
Lists: pgsql-hackers 
Tomas Vondra wrote:

> OK, this did the trick. And just as I suspected, it seems to be due to doing
> memcpy+offsetof when serializing the statistic into a bytea. The attached
> patch fixes that for me. Can you test it on your build?

Buildfarm member skink confirms that this is fixed.  Thanks!

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix uninitialized memory propagation mistakes