Re: BUG #14057: vacuum setting reltuples=0 for tables with >0 tuples

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>, pgsql-bugs@postgresql.org
Date: 2017-03-16T21:35:55Z
Lists: pgsql-bugs
On 2017-03-16 17:28:24 -0400, Tom Lane wrote:
> Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> > "Andres" == Andres Freund <andres@anarazel.de> writes:
> >  Andres> Seems like a good thing to include in the tree.  I'd be ok with
> >  Andres> just including the simpler version in the relevant branches.
> 
> > Ok.
> 
> I dunno ... there doesn't seem to be any meaningful portability risk
> here, and it's not clear to me what class of future bug this test might
> hope to catch.  Do we really need to spend test cycles forevermore on
> this?

We had previous bugs around this, so it doesn't seem like a bad idea to
test it.  Also it should be so short in comparison to the rest of the
isolationtests that it won't matter wrt total runtime?

- Andres


Commits

  1. Avoid having vacuum set reltuples to 0 on non-empty relations in the