Re: [PATCH] Suppress Clang 3.9 warnings

Noah Misch <noah@leadboat.com>

From: Noah Misch <noah@leadboat.com>
To: Aleksander Alekseev <a.alekseev@postgrespro.ru>
Cc: David Steele <david@pgmasters.net>, PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-03-16T06:55:20Z
Lists: pgsql-hackers
This mailing list does not welcome top-post replies.

On Wed, Mar 15, 2017 at 12:04:11PM +0300, Aleksander Alekseev wrote:
> > This is wrong on platforms that do have strlcpy() in libc.
> 
> If it no too much trouble could you please explain what will happen
> on such platforms?

Both port.h and a system header will furnish a strlcpy() declaration.  The #if
you modified exists to avoid that, and your change would make it ineffective
for Clang.  This will have no symptoms, or it will elicit a warning.

> On what platform did you check it?

None.


Commits

  1. Suppress implicit-conversion warnings seen with newer clang versions.