Re: Upgrading postmaster's log messages about bind/listen errors
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Euler Taveira <euler@timbira.com.br>, Robert Haas <robertmhaas@gmail.com>, Joe Conway <mail@joeconway.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-03-16T02:13:14Z
Lists: pgsql-hackers
On Tue, Mar 14, 2017 at 12:50:09PM -0400, Tom Lane wrote: > I wrote: > >> I think that what would actually be of some use nowadays is a LOG-level > >> message emitted if the wraparound *isn't* activated immediately at start. > >> But otherwise, we should follow the rule that silence is golden. > > > Concretely, how about the attached? It preserves the original > > "protections are now enabled" message at LOG level, but emits it only > > when oldestOffsetKnown becomes true *after* startup. Meanwhile, if > > oldestOffsetKnown is still not true at the conclusion of TrimMultiXact, > > then it emits a new LOG message about "protections are not active". > > I realized that the second of these is not necessary because it's > redundant with the message about "MultiXact member wraparound protections > are disabled because oldest checkpointed MultiXact %u does not exist on > disk". Pushed without that. Gee, I kind of like the new messages: LOG: listening on IPv4 address "127.0.0.1", port 5432 LOG: listening on Unix socket "/tmp/.s.PGSQL.5432" -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
Commits
-
Make logging about multixact wraparound protection less chatty.
- 5ed6fff6b729 10.0 landed
-
Improve postmaster's logging of listen socket creation.
- f9dfa5c97766 10.0 landed
-
Reduce log verbosity of startup/shutdown for launcher subprocesses.
- 6ec4c8584c45 10.0 landed