Re: pgsql: Remove objname/objargs split for referring to objects

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-committers@postgresql.org
Date: 2017-03-15T15:18:29Z
Lists: pgsql-hackers
Peter Eisentraut wrote:
> Remove objname/objargs split for referring to objects

I don't know if this is the guilty commit, but I'm now getting these
compiler warnings:


/pgsql/source/master/src/backend/catalog/objectaddress.c: In function 'get_object_address':
/pgsql/source/master/src/backend/catalog/objectaddress.c:1624:33: warning: 'typenames[1]' may be used uninitialized in this function [-Wmaybe-uninitialized]
       ereport(ERROR,
                                 ^
/pgsql/source/master/src/backend/catalog/objectaddress.c:1578:8: note: 'typenames[1]' was declared here
  char    *typenames[2];
        ^
/pgsql/source/master/src/backend/catalog/objectaddress.c:1624:33: warning: 'typenames[0]' may be used uninitialized in this function [-Wmaybe-uninitialized]
       ereport(ERROR,
                                 ^
/pgsql/source/master/src/backend/catalog/objectaddress.c:1578:8: note: 'typenames[0]' was declared here
  char    *typenames[2];
        ^

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Fix ancient get_object_address_opf_member bug

  2. Remove objname/objargs split for referring to objects

  3. Support opfamily members in get_object_address