Re: Need a builtin way to run all tests faster manner
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Stephen Frost <sfrost@snowman.net>, pgsql-hackers@postgresql.org
Date: 2017-03-14T20:31:08Z
Lists: pgsql-hackers
Attachments
- 0001-Improve-isolation-regression-tests-infrastructure.patch (text/x-patch)
On 2017-03-13 00:35:06 -0400, Tom Lane wrote: > Andres Freund <andres@anarazel.de> writes: > > On 2017-03-11 22:14:07 -0500, Tom Lane wrote: > >> This looks generally sane to me, although I'm not very happy about folding > >> the "$(MKDIR_P) output_iso" call into pg_isolation_regress_check --- that > >> seems weird and unlike the way it's done for the regular regression test > >> case. > > > Yea, not super happy about that either - alternatively we could fold it > > into pg_regress. > > Yeah, teaching pg_regress to auto-create the --temp-instance directory > seems perfectly sane from here. I was thinking about outputdir, not temp-instance. The latter is already created: /* make the temp instance top directory */ make_directory(temp_instance); Attached is an updated patch that creates outputdir if necessary. This is possibly going to trigger a time-to-check-time-to-use coverity warning, but the rest of pg_regress does if(!exists) mkdir() type logic, so I did the same. Besides the pg_regress change, the only thing I've changed is to remove the in-line "$(MKDIR_P) output_iso && \". - Andres
Commits
-
Improve isolation tests infrastructure.
- 60f826c5e624 10.0 landed