Re: [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-03-13T15:31:23Z
Lists: pgsql-hackers
Tom Lane wrote: > Robert Haas <robertmhaas@gmail.com> writes: > > So now on every startup I get this: > > > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv6 address "::1" > > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv4 address "127.0.0.1" > > 2017-03-13 10:08:49.400 EDT [90059] LOG: listening on Unix address > > "/tmp/.s.PGSQL.5432" > > > I think the idea that this is worth three lines of log output (out of > > a total of six) is hard to stomach. > > You were in the minority before on the usefulness of this output, and > I think you still are. Personally I've already found it useful to be > able to check that buildfarm runs are binding to (only) the addresses > they're supposed to. I think it's good to have it, but I would argue that it should be a single line that lists all the addresses instead. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Include port number when logging successful binding to a TCP port.
- 2b32ac2a59df 10.0 landed
-
Improve postmaster's logging of listen socket creation.
- f9dfa5c97766 10.0 cited