Re: [REVIEW] macaddr 64 bit (EUI-64) datatype support
Stephen Frost <sfrost@snowman.net>
From: Stephen Frost <sfrost@snowman.net>
To: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Vitaly Burovoy <vitaly.burovoy@gmail.com>, Kuntal Ghosh <kuntalghosh.2007@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Shay Rojansky <roji@roji.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Julien Rouhaud <julien.rouhaud@dalibo.com>, Craig Ringer <craig@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-03-12T19:52:30Z
Lists: pgsql-hackers
Attachments
- mac_eui64_support_v12.patch (text/x-diff) patch v12
Greetings, * Stephen Frost (sfrost@snowman.net) wrote: > * Stephen Frost (sfrost@snowman.net) wrote: > > * Haribabu Kommi (kommi.haribabu@gmail.com) wrote: > > > On Wed, Feb 1, 2017 at 6:27 AM, Vitaly Burovoy <vitaly.burovoy@gmail.com> wrote: > > > > The new status of this patch is: Ready for Committer > > > > > > Thanks for the review. > > > > I've started taking a look at this with an eye towards committing it > > soon. > > I've spent a good bit of time going over this, possibly even more than > it was worth, but hopefully we'll see people making use of this data > type with PG10 and as more IPv6 deployment happens. And, naturally, re-reading the email as it hit the list made me realize that the documentation/error-message incorrectly said "3rd and 4th" bytes were being set to FF and FE, when it's actually the 4th and 5th byte. The code was correct, just the documentation and the error message had the wrong numbers. The commit message is also correct. As a reminder to myself, this will also need a catversion bump when it gets committed, of course. Updated patch attached. Thanks! Stephen
Commits
-
Add support for EUI-64 MAC addresses as macaddr8
- c7a9fa399d55 10.0 landed
-
perltidy pg_dump TAP tests
- 6af8b89adba1 10.0 cited