Horton

Re: contrib modules and relkind check

Stephen Frost <sfrost@snowman.net>

View thread View on postgr.es
From: Stephen Frost <sfrost@snowman.net>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Michael Paquier <michael.paquier@gmail.com>, Corey Huinker <corey.huinker@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-03-09T13:25:38Z
Lists: pgsql-hackers 
Amit, Michael,

* Amit Langote (Langote_Amit_f8@lab.ntt.co.jp) wrote:
> On 2017/03/09 11:51, Michael Paquier wrote:
> > On Wed, Mar 8, 2017 at 5:10 PM, Amit Langote
> > <Langote_Amit_f8@lab.ntt.co.jp> wrote:
> >> On 2017/03/08 16:47, Michael Paquier wrote:
> >>> Only regular tables are tested as valid objects. Testing toast tables
> >>> is not worth the complication. Could you add as well a matview?
> >>
> >> Done in the attached updated patch.
> > 
> > +select count(*) > 0 from pg_visibility('matview');
> > + ?column?
> > +----------
> > + f
> > +(1 row)
> > That's quite a generic name :) You may want to use less common names
> > in your tests.
> 
> I agree.  Updated patch attached.
> 
> > OK, I am marking that as ready for committer.

I'm starting to look over this, seems pretty straight-forward.

Barring issues, I should get it committed in probably an hour or two.

Thanks!

Stephen

Commits

  1. Add relkind checks to certain contrib modules