Re: Change in "policy" on dump ordering?
Michael Banck <michael.banck@credativ.de>
From: Michael Banck <michael.banck@credativ.de>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Jim Nasby <Jim.Nasby@BlueTreble.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-03-06T08:33:43Z
Lists: pgsql-hackers
Hi, On Sat, Mar 04, 2017 at 02:49:36PM -0500, Peter Eisentraut wrote: > On 3/1/17 08:36, Peter Eisentraut wrote: > > On 2/22/17 18:24, Jim Nasby wrote: > >>> Yes, by that logic matview refresh should always be last. > >> > >> Patches for head attached. > >> > >> RLS was the first item added after DO_REFRESH_MATVIEW, which was added > >> in 9.5. So if we want to treat this as a bug, they'd need to be patched > >> as well, which is a simple matter of swapping 33 and 34. > > > > I wonder whether we should emphasize this change by assigning > > DO_REFRESH_MATVIEW a higher number, like 100? > > Since there wasn't any interest in that idea, I have committed Jim's > patch as is. Would this be a candidate for backpatching, or is the behaviour change in pg_dump trumping the issues it solves? Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.banck@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
Commits
-
Fix pg_dump/pg_restore to emit REFRESH MATERIALIZED VIEW commands last.
- b93217653b68 9.4.13 landed
- 65048cf23dba 9.5.8 landed
- 3d76328298ca 9.6.4 landed
- 3eb9a5e7c4c9 10.0 landed
- 035bb82222bc 9.3.18 landed