[PATCH] Suppress Clang 3.9 warnings
Aleksander Alekseev <a.alekseev@postgrespro.ru>
From: Aleksander Alekseev <a.alekseev@postgrespro.ru>
To: pgsql-hackers@postgresql.org
Date: 2017-02-20T14:12:39Z
Lists: pgsql-hackers
Attachments
- suppress-clang39-warnings.patch (text/x-diff) patch
Hello. I've just tried to build PostgreSQL with Clang 3.9.1 (default version currently available in Arch Linux) and noticed that it outputs lots of warning messages. Most of them are result of a bug in Clang itself: ``` postinit.c:846:3: note: include the header <string.h> or explicitly provide a declaration for 'strlcpy' ``` I've reported it to Clang developers almost a year ago but apparently no one cares. You can find all the details in a corresponding thread [1]. Frankly I'm not sure what to do about it. The rest of warnings looks more like something we could easily deal with: ``` xloginsert.c:742:18: warning: implicit conversion from 'int' to 'char' changes value from 253 to -3 [-Wconstant-conversion] ``` Patch that fixes these warnings is attached to this email. [1] http://lists.llvm.org/pipermail/cfe-dev/2016-March/048126.html -- Best regards, Aleksander Alekseev
Commits
-
Suppress implicit-conversion warnings seen with newer clang versions.
- 8cfeaecfc76a 10.0 landed
- 8433e0b40e0d 9.6.3 landed
- 16e815279135 9.5.7 landed