Thread

Commits

Doc: fix typo in logicaldecoding.sgml.
- 19c324d9fb4d 9.4.12 landed
- e0084c32f634 9.5.7 landed
- b1dc2af1a221 9.6.3 landed
- adb67d67f0f2 10.0 landed

output_mode should be output_type

Tomonari Katsumata <t.katsumata1122@gmail.com> — 2017-02-15T07:21:15Z

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/9.6/static/logicaldecoding-output-plugin.html
Description:

Hello.

I found documentation bug.
[47.6.3. Output Modes]
https://www.postgresql.org/docs/9.6/static/logicaldecoding-output-plugin.html#LOGICALDECODING-OUTPUT-MODE

According to this document, &quot;output_mode&quot; parameter is used for changing
output mode. But test_decoding uses &quot;output_type&quot; like below.

--- test_decoding.c ---
 155                 opt-&gt;output_type = OUTPUT_PLUGIN_BINARY_OUTPUT;
-----------------------

Sorry for trivial comment, but please fix this!

Re: output_mode should be output_type

Tom Lane <tgl@sss.pgh.pa.us> — 2017-02-15T22:22:12Z

t.katsumata1122@gmail.com writes:
> I found documentation bug.
> [47.6.3. Output Modes]
> https://www.postgresql.org/docs/9.6/static/logicaldecoding-output-plugin.html#LOGICALDECODING-OUTPUT-MODE

> According to this document, &quot;output_mode&quot; parameter is used for changing
> output mode. But test_decoding uses &quot;output_type&quot; like below.

Yup, you're right.  Surprising that nobody noticed this before ...
thanks for reporting it!

			regards, tom lane