Re: Failure in commit_ts tap tests

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Pavan Deolasee <pavan.deolasee@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-01-27T12:22:06Z
Lists: pgsql-hackers
Andrew Dunstan wrote:

> On 01/26/2017 03:50 PM, Alvaro Herrera wrote:

> > It is really quite annoying that the buildfarm doesn't do what stock
> > tests do.  What about pushing a bit stronger for having these
> > optimizations as part of the standard build run, instead of being only
> > in the buildfarm client script?
> 
> There is nothing that the buildfarm does that's not a stock test. What
> it does is run the stock tests with USE_MODULE_DB=1 (which you can do
> too). That is something provided for in our Make files. The reason is
> that otherwise we constantly overwrite the regression database. That can
> make it a lot harder to go back after a buildfarm run and find errors.

There is a lot that you *can* do using the stock makefiles, but that
"make check-world" doesn't do.  Why aren't we using USE_MODULE_DB=1 in
"make check-world", is my question.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Remove test for COMMENT ON DATABASE

  2. tests: Use the right Perl operator