Re: Failure in commit_ts tap tests

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, Pavan Deolasee <pavan.deolasee@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-01-26T20:50:52Z
Lists: pgsql-hackers
Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> > On 01/24/2017 05:17 AM, Alvaro Herrera wrote:
> >> Maybe we can drop that line and put it back once we get COMMENT ON
> >> CURRENT_DATABASE.
> 
> > Works for me.
> 
> If that's enough to get the "make check" cases passing in the buildfarm,
> then +1.

Okay, done.

It is really quite annoying that the buildfarm doesn't do what stock
tests do.  What about pushing a bit stronger for having these
optimizations as part of the standard build run, instead of being only
in the buildfarm client script?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Remove test for COMMENT ON DATABASE

  2. tests: Use the right Perl operator