Re: Vacuum: allow usage of more than 1GB of work mem
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Claudio Freire <klaussfreire@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Pavan Deolasee <pavan.deolasee@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Greg Stark <stark@mit.edu>, Simon Riggs <simon@2ndquadrant.com>, Jim Nasby <Jim.Nasby@bluetreble.com>, PostgreSQL-Dev <pgsql-hackers@postgresql.org>
Date: 2017-01-20T21:25:18Z
Lists: pgsql-hackers
Attachments
You posted two patches with this preamble: Claudio Freire wrote: > Attached is the raw output of the test, the script used to create it, > and just in case the patch set used. I believe it's the same as the > last one I posted, just rebased. There was no discussion whatsoever of the "prefetch" patch in this thread; and as far as I can see, nobody even mentioned such an idea in the thread. This prefetch patch appeared out of the blue and there was no discussion about it that I can see. Now I was about to push it after some minor tweaks, and went to search where was its justification, only to see that there was none. Did anybody run tests with this patch? I attach it now one more time. My version is based on the latest Claudio posted at https://postgr.es/m/CAGTBQpa464RugxYwxLTtDi=Syv9GnGFcJK8uZb2fR6NDDqULaw@mail.gmail.com I don't know if there are differences to the version first posted. I only changed the magic number 32 to a #define, and added a CHECK_FOR_INTERRUPTS in the prefetching loop. FWIW, I think this patch is completely separate from the maint_work_mem patch and should have had its own thread and its own commitfest entry. I intend to get a look at the other patch next week, after pushing this one. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Prefetch blocks during lazy vacuum's truncation scan
- 7e26e02eec90 10.0 landed
-
Explain unaccounted for space in pgstattuple.
- 71f996d22125 10.0 cited