Horton

Re: Declarative partitioning - another take

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Amit Langote <amitlangote09@gmail.com>, Dmitry Ivanov <d.ivanov@postgrespro.ru>, Michael Paquier <michael.paquier@gmail.com>, Erik Rijkers <er@xs4all.nl>, Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>, pgsql-hackers-owner@postgresql.org
Date: 2017-01-20T06:15:20Z
Lists: pgsql-hackers 
On 2017-01-19 14:18:23 -0500, Robert Haas wrote:
> Committed.

One of the patches around this topic committed recently seems to cause
valgrind failures like
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2017-01-19%2008%3A40%3A02
:
==24969== Conditional jump or move depends on uninitialised value(s)
==24969==    at 0x4C38DA: btint4cmp (nbtcompare.c:97)
==24969==    by 0x83860C: FunctionCall2Coll (fmgr.c:1318)
==24969==    by 0x536643: partition_bounds_equal (partition.c:627)
==24969==    by 0x820864: equalPartitionDescs (relcache.c:1203)
==24969==    by 0x82423A: RelationClearRelation (relcache.c:2553)
==24969==    by 0x8248BA: RelationFlushRelation (relcache.c:2662)
==24969==    by 0x824983: RelationCacheInvalidateEntry (relcache.c:2714)
==24969==    by 0x81D9D6: LocalExecuteInvalidationMessage (inval.c:568)
==24969==    by 0x81CB0D: ProcessInvalidationMessages (inval.c:444)
==24969==    by 0x81D3CB: CommandEndInvalidationMessages (inval.c:1056)
==24969==    by 0x4F6735: AtCCI_LocalCache (xact.c:1374)
==24969==    by 0x4F8249: CommandCounterIncrement (xact.c:957)
==24969==  Uninitialised value was created by a heap allocation
==24969==    at 0x85AA83: palloc (mcxt.c:914)
==24969==    by 0x53648E: RelationBuildPartitionDesc (partition.c:528)
==24969==    by 0x823F93: RelationBuildDesc (relcache.c:1348)
==24969==    by 0x8241DB: RelationClearRelation (relcache.c:2524)
==24969==    by 0x8248BA: RelationFlushRelation (relcache.c:2662)
==24969==    by 0x824983: RelationCacheInvalidateEntry (relcache.c:2714)
==24969==    by 0x81D9D6: LocalExecuteInvalidationMessage (inval.c:568)
==24969==    by 0x81CB0D: ProcessInvalidationMessages (inval.c:444)
==24969==    by 0x81D3CB: CommandEndInvalidationMessages (inval.c:1056)
==24969==    by 0x4F6735: AtCCI_LocalCache (xact.c:1374)
==24969==    by 0x4F8249: CommandCounterIncrement (xact.c:957)
==24969==    by 0x82538B: RelationSetNewRelfilenode (relcache.c:3490)
==24969== 
==24969== VALGRINDERROR-END


Regards,

Andres

Commits

  1. Fix typo.

  2. Document trigger-firing behavior for inheritance/partitioning.

  3. Fire per-statement triggers on partitioned tables.

  4. Set ecxt_scantuple correctly for tuple routing.

  5. Fix interaction of partitioned tables with BulkInsertState.

  6. Avoid core dump for empty prepared statement in an aborted transaction.

  7. Fix some problems in check_new_partition_bound().

  8. Remove unnecessary arguments from partitioning functions.

  9. Fix reporting of constraint violations for table partitioning.

  10. Fix tuple routing in cases where tuple descriptors don't match.

  11. Invalid parent's relcache after CREATE TABLE .. PARTITION OF.

  12. Doc: improve documentation about inheritance.