Re: Improving RLS planning

Stephen Frost <sfrost@snowman.net>

From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-01-17T17:47:08Z
Lists: pgsql-hackers
Tom,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > * Tom Lane (tgl@sss.pgh.pa.us) wrote:
> >> Here's an updated version of the RLS planning patch that gets rid of
> >> the incorrect interaction with Query.hasRowSecurity and adjusts
> >> terminology as agreed.
> 
> > I've spent a fair bit of time going over this change to understand it,
> > how it works, and how it changes the way RLS and securiy barrier views
> > work.
> 
> Thanks for the review.  Attached is an updated patch that I believe
> addresses all of the review comments so far.  The code is unchanged from
> v2, but I improved the README, some comments, and the regression tests.

I've reviewed your updates and they answer all of my comments and I
appreciate the EC regression tests you added.

I also agree with Dean's down-thread suggested regression test change.

Thanks!

Stephen

Commits

  1. Improve RLS planning by marking individual quals with security levels.