Horton

Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Date: 2017-01-17T01:00:39Z
Lists: pgsql-hackers

Attachments

On 2017-01-16 12:52:14 -0800, Andres Freund wrote:
> > > Comments?
> >
> > Hard to comment on your other points without a patch to look at.
> 
> Attached the current version. There's a *lot* of pending cleanup needed
> (especially in execQual.c) removing outdated code/comments etc, but this
> seems good enough for a first review.  I'd want that cleanup done in a
> separate patch anyway.

Here's a version with a lot of that pending cleanup added (and other
light updates).  Most notably all SRF related code is gone from
executor/ excepting ExecMakeFunctionResultSet and nodeSetResult.  I'm
sure there's minor remaining references somewhere, but that's the
majority.

I think when committing this the first two patches should be combined,
but the later cleanup patch one not.  It hides too many of the actually
relevant changes.

Greetings,

Andres Freund

Commits

  1. Remove obsoleted code relating to targetlist SRF evaluation.

  2. Doc: improve documentation of new SRF-in-tlist behavior.

  3. Move targetlist SRF handling from expression evaluation to new executor node.

  4. Don't split up SRFs when choosing to postpone SELECT output expressions.