Re: additional contrib test suites
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: David Steele <david@pgmasters.net>, Michael Paquier <michael.paquier@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@enterprisedb.com>
Date: 2017-09-22T17:21:09Z
Lists: pgsql-hackers
On 2017-09-18 09:54:52 -0400, Peter Eisentraut wrote: > On 9/16/17 08:10, David Steele wrote: > >>> (5) drop contrib/chkpass altogether, on the grounds that it's too badly > >>> designed, and too obsolete crypto-wise, to be useful or supportable. > >> crypt() uses the 7 lowest characters, which makes for 7.2e16 values, > >> so I would be fine with (5), then (4) as the test suite is not > >> portable. > > I'd prefer 5, but can go with 4. > > > > I get that users need to store their own passwords, but we have support > > for SHA1 via the crypto module which seems by far the better choice. > > I'm also tempted to just remove it. It uses bad/outdated security > practices and it's also not ideal as an example module. Any objections? Uhm. I'm not objecting, but I doubt people really noticed your question in a thread about additional contrib test suites. Greetings, Andres Freund
Commits
-
Remove contrib/chkpass
- 5d3cad564729 11.0 landed
-
doc: Clarify pg_inherits description
- 0b554e4e63a4 11.0 cited